Harden GitHub Actions workflow #1122
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 2 2
Lines 434 434
Branches 51 51
=======================================
Hits 388 388
Misses 31 31
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seifertm
force-pushed
the
harden-gh-actions-workflow
branch
from
2615ff6 to
60cd123
Compare
seifertm
force-pushed
the
harden-gh-actions-workflow
branch
from
5cc6d17 to
60cd123
Compare
|
@seifertm looks like you marked my suggested change as resolved by mistake. |
Indeed, thank you! I corrected that. |
This detects changed action code for the same tag.
This is already tracked in pytest-dev#700
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
seifertm
force-pushed
the
harden-gh-actions-workflow
branch
from
b240714 to
3ad8609
Compare
| uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4 # zizmor: ignore[use-trusted-publishing] # see #700 | ||
| with: | ||
| attestations: true | ||
| packages-dir: dist |
There was a problem hiding this comment.
I assume that the ignore was related to password that's no longer there? Also, all these inputs match defaults.
| uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4 # zizmor: ignore[use-trusted-publishing] # see #700 | |
| with: | |
| attestations: true | |
| packages-dir: dist | |
| uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4 |
This PR introduces zizmor for linting GitHub Actions Workflows and addresses all of its findings.
Zizmor is used both as a pre-commit hook and a separate job in the pipeline. This is due to the fact that some analyses require a GitHub token, which not all developers may have readily available.